London | 26-ITP-May | Russom Gebremeskel | Sprint 1 | Form Controls#1292
Open
russom-g wants to merge 1 commit into
Open
London | 26-ITP-May | Russom Gebremeskel | Sprint 1 | Form Controls#1292russom-g wants to merge 1 commit into
russom-g wants to merge 1 commit into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
russom-g
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
russom-g
added
the
Needs Review
Luro91
added
the
Review in progress
Luro91
reviewed
May 20, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
The code works already as expected. I have some comments on the formatting and the styles in the html file
Comment on lines
+9
to
+49
| <style> | ||
| body { | ||
| font-family: Arial, sans-serif; | ||
| margin: 0; | ||
| padding: 0; | ||
| } | ||
| header { | ||
| color: black; | ||
| padding: 1rem; | ||
| text-align: center; | ||
| margin-bottom: 20px; | ||
| } | ||
| main { | ||
| padding: 1rem; | ||
| } | ||
| form { | ||
| max-width: 400px; | ||
| margin: 0 auto; | ||
| } | ||
| div { | ||
| margin-bottom: 1rem; | ||
| } | ||
| label { | ||
| display: block; | ||
| margin-bottom: 0.5rem; | ||
| } | ||
| input, | ||
| select { | ||
| width: 100%; | ||
| padding: 0.5rem; | ||
| box-sizing: border-box; | ||
| } | ||
| button { | ||
| padding: 0.5rem 1rem; | ||
| background-color: #333; | ||
| color: white; | ||
| border: none; | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| </style> |
There was a problem hiding this comment.
How can you separate the styling from the html code to reduce the file size?
| <div> | ||
|
|
||
| <label for="name"> Name:</label> | ||
| <input type="text" id="name" name="name" required pattern="\S{2,}" title="Please enter at least two non-space characters."> |
There was a problem hiding this comment.
Well done on ensuring the required pattern is used for the name
Comment on lines
+59
to
+63
|
|
||
| <label for="name"> Name:</label> | ||
| <input type="text" id="name" name="name" required pattern="\S{2,}" title="Please enter at least two non-space characters."> | ||
| </div> | ||
|
|
There was a problem hiding this comment.
I see some new lines that are not needed. How can you ensure consistent formatting in your code automatically?
Luro91
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
-I wrote the HTML code.
-I tested it on light house.
-I added some CSS code to get 100% in light house.
Questions